Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applies bug fixes to UI screens #523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Oct 28, 2024

Description

Before - archived models list label:
Screenshot 2024-10-25 at 10 45 33 AM
After - archived models list label:
Screenshot 2024-10-25 at 10 45 06 AM

Before - archived models list search filter:

Screenshot 2024-10-28 at 11 41 57 AM

After - archived models list search filter:
Screenshot 2024-10-28 at 11 49 16 AM

Before - archived models list pagination:

Screenshot 2024-10-25 at 10 52 26 AM

After - archived models list pagination:

Screenshot 2024-10-25 at 10 52 52 AM

Before - close button border radius:
Screenshot 2024-10-28 at 12 07 39 PM

After - close button border radius
Screenshot 2024-10-28 at 11 40 54 AM

Before - archive version modal
Screenshot 2024-10-25 at 11 08 29 AM

After - archive version modal
Screenshot 2024-10-25 at 11 08 01 AM

How Has This Been Tested?

  1. Model Registry list view -> Actions menu next to "Register Model" button in toolbar -> Click "View Archived Models" -> Archived models list view -> Click on a model in the list -> Verify label text color is correct
  2. Model Registry list view -> Actions menu next to "Register Model" button in toolbar -> Click "View Archived Models" -> Archived models list view -> Verify search filter and pagination has correct styling applied
  3. Model Registry list view -> Actions menu next to "Register Model" button in toolbar -> Click "View Archived Models" -> Archived models list view -> Labels column -> click on "1 more" overflow chip. Verify close button border radius is round.
  4. Click on a kebab menu in any list view to toggle a modal. Verify modal styling has been updated.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Jenny <[email protected]>

update search filter styling for archived models list

Signed-off-by: Jenny <[email protected]>

fix tests

Signed-off-by: Jenny <[email protected]>

fix tests
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Griffin-Sullivan
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants